Add tests for GpuInSet #3397
Merged
Add tests for GpuInSet #3397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sperlingxx lovedreamf@gmail.com
Closes #2764
After tests, I found that current implementation of
GpuInSetcan fully adapt SPARK-35316. If I understand correctly, the datatype of needles is the same as haystack, since we build the needles from child's datatype. The potential problem is what if some values in needles can not cast to child's datatype, such as:select cast(a as int) in (1L, 2L, 3147483647L). The lit value3147483647Lcan not be casted to INT32 due to out of range. It seems we don't need to worry about that, because these outliers will be removed inUnwrapCastInBinaryComparsion.