Fix canonicalization regression with Spark 3.2 #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gression when running with Spark 3.2 Signed-off-by: Andy Grove <andygrove@nvidia.com>
54 tasks
revans2
approved these changes
Sep 7, 2021
|
build |
abellina
reviewed
Sep 8, 2021
| case a: AttributeReference => a.withExprId(ExprId(0)) | ||
| } | ||
| case Partial | Complete => aggregateFunction | ||
| case Complete => aggregateFunction |
There was a problem hiding this comment.
What happens if we normalize all? (i.e. no match).
There was a problem hiding this comment.
I did wonder about that as well but I really don't know. Prior to this PR, our code matches Spark, so there seems to be a reason not to apply this in all cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Grove andygrove@nvidia.com
Partially address #3400
This PR extends the
exprIdnormalization logic to also apply to aggregate expressions wheremode=Partialand fixes two test failures (HashAggregatesSuite and ExpandExecSuite) when running against Spark 3.2.See #3400 for more detail on why the behavior is different with Spark 3.2