-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decrease pre_merge_ci parallelism to 4 and reordering time-consuming tests #3455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peixin Li <pxli@nyu.edu>
pxLi
requested review from
GaryShen2008,
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
September 13, 2021 02:00
build |
pxLi
force-pushed
the
pre_merge_ci_2_parallel-4
branch
from
September 13, 2021 02:53
f8e91b9
to
140f334
Compare
build |
pxLi
force-pushed
the
pre_merge_ci_2_parallel-4
branch
from
September 13, 2021 04:53
5fba2d3
to
7d74179
Compare
build |
pxLi
changed the title
Decrease pre_merge_ci parallelism to 4
Decrease pre_merge_ci parallelism to 4 and reordering time-consuming tests
Sep 13, 2021
build |
pxLi
force-pushed
the
pre_merge_ci_2_parallel-4
branch
from
September 13, 2021 05:20
7d853db
to
3f93512
Compare
build |
build |
build |
zhanga5
previously approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peixin Li pxli@nyu.edu
we added more test cases which made the mem usage for ci_2 in an unstable state.
Decrease it to 4 from 5, and will keep monitoring this.
Rebalance ci_1 and ci_2 to leave space for 320 UT
Also put expensive test cases to the head of xdist worker queue to avoid some cases got assigned to worker too late and increase the total time. Saved ~5-10 mins w/ lower mem usage (10-20% off)