Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fixes and IDE instructions #3474

Merged
merged 10 commits into from
Sep 15, 2021
Merged

Build fixes and IDE instructions #3474

merged 10 commits into from
Sep 15, 2021

Conversation

gerashegalov
Copy link
Collaborator

@gerashegalov gerashegalov commented Sep 14, 2021 •
edited
Loading

  • IDEA project setup instructions, surely more will be needed
  • allow skipping scalastyle in repeated builds
  • remove temporary !buildver profiles adding wrong directories in IDEA
  • rename spark311+-apache to spark311until320-apache to correctly reflect applicable shims

Fixes #3338

Signed-off-by: Gera Shegalov gera@apache.org

@gerashegalov
init
09e062a
@gerashegalov
wip
9330183
@gerashegalov
Rename spark311+-apache
9681012
@gerashegalov
IDE setup instructions and minor fixes
db0b10e 
Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov
Shim profiles and CONTRIBUTING.md
dee1be9 
Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov gerashegalov self-assigned this Sep 14, 2021
@gerashegalov gerashegalov added this to the Sep 13 - Sep 24 milestone Sep 14, 2021
@gerashegalov gerashegalov added build Related to CI / CD or cleanly building documentation Improvements or additions to documentation labels Sep 14, 2021
@gerashegalov
Copy link
Collaborator Author

build

tgravescs
tgravescs reviewed Sep 14, 2021
View reviewed changes
shims/pom.xml Outdated Show resolved Hide resolved
@tgravescs
Copy link
Collaborator

overall looks good, couple nits

revans2
revans2 reviewed Sep 14, 2021
View reviewed changes
build/buildall Outdated Show resolved Hide resolved
build/buildall Show resolved Hide resolved
@tgravescs
Copy link
Collaborator

sid enote this passed databricks tests: https://blossom.nvidia.com/sw-gpu-spark-jenkins/job/rapids_databricks-for-developer/3/

@gerashegalov
Copy link
Collaborator Author

build

tgravescs
tgravescs reviewed Sep 15, 2021
View reviewed changes
pom.xml Show resolved Hide resolved
@gerashegalov
Copy link
Collaborator Author

build

@tgravescs
Copy link
Collaborator

@revans2 you good with updates?

revans2
revans2 approved these changes Sep 15, 2021
View reviewed changes
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not had a chance to test that it has fixed all of my problems, but it is definitely a lot better than it was before.

@tgravescs
Copy link
Collaborator

ok going to merge then.

@tgravescs tgravescs merged commit afe1952 into NVIDIA:branch-21.10 Sep 15, 2021
@gerashegalov gerashegalov deleted the ideaSetup branch September 15, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgravescs tgravescs tgravescs approved these changes

@revans2 revans2 revans2 approved these changes

@andygrove andygrove andygrove approved these changes

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@jlowe jlowe Awaiting requested review from jlowe jlowe is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

Assignees

@gerashegalov gerashegalov

Labels
build Related to CI / CD or cleanly building documentation Improvements or additions to documentation
Projects
None yet
Milestone
Sep 13 - Sep 24
Development

Successfully merging this pull request may close these issues.

[DOC] Instructions to setup IDEs
4 participants
@gerashegalov @tgravescs @andygrove @revans2