Test with Spark 3.2.1-SNAPSHOT #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowe
reviewed
Sep 14, 2021
tgravescs
reviewed
Sep 14, 2021
There was a problem hiding this comment.
You need this too:
+++ b/shims/spark320/src/main/scala/com/nvidia/spark/rapids/shims/spark320/SparkShimServiceProvider.scala
@@ -20,7 +20,9 @@ import com.nvidia.spark.rapids.{SparkShims, SparkShimVersion}
object SparkShimServiceProvider {
val VERSION320 = SparkShimVersion(3, 2, 0)
- val VERSIONNAMES: Seq[String] = Seq(VERSION320)
+ // temporarily allow 3.2.1 while 3.2.0 release candidates are being produced
+ val VERSION321 = SparkShimVersion(3, 2, 1)
+ val VERSIONNAMES: Seq[String] = Seq(VERSION320, VERSION321)
.flatMap(v => Seq(s"$v", s"$v-SNAPSHOT"))
}
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
force-pushed
the
spark-3.2-testing
branch
from
291e228 to
55c0e54
Compare
tgravescs
reviewed
Sep 14, 2021
| @@ -19,7 +19,8 @@ package com.nvidia.spark.rapids.shims.spark320 | |||
| import com.nvidia.spark.rapids.{SparkShims, SparkShimVersion} | |||
|
|
|||
| object SparkShimServiceProvider { | |||
| val VERSION320 = SparkShimVersion(3, 2, 0) | |||
| // temporarily allow 3.2.1 while 3.2.0 release candidates are being produced | |||
| val VERSION320 = SparkShimVersion(3, 2, 1) | |||
| val VERSIONNAMES: Seq[String] = Seq(VERSION320) | |||
There was a problem hiding this comment.
referencing version320 which was removed. Also I think we should leave 320 in there in case someone is using older snapshot.
There was a problem hiding this comment.
never mind on the name, realize VERSION320 just points to 3.2.1. I do think we should leave 3.2.0 as well though
There was a problem hiding this comment.
@tgravescs I have updated this now
|
I tested with this diff and I was able to test shuffle with the 3.2.0 shim against spark 3.2.1. |
andygrove
requested review from
GaryShen2008,
NvTimLiu and
revans2
as code owners
tgravescs
approved these changes
Sep 15, 2021
|
build |
andygrove
added a commit
to andygrove/spark-rapids
that referenced
this pull request
Sep 15, 2021
* Test with Spark 3.2.1-SNAPSHOT Signed-off-by: Andy Grove <andygrove@nvidia.com> * tests now run against 3.2.1-SNAPSHOT * address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change spark320 version to 3.2.1-SNAPSHOT so we can test Spark 3.2 support in CI. This is necessary as a temporary measure until 3.2.0 is released because Spark no longer publishes 3.2.0-SNAPSHOT releases and we depend on a fix that went in since they stopped publishing them.