Re-enable spark.rapids.shims-provider-override #3497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The class name provided can be an arbitrary implementation of SparkShimServiceProvider - If the Shim is tested with other shims together and requires its own Parallel World, then it should follow the same conventions as existing Shims: the last component in its package name should be the root directory in the combined rapids-4-spark jar. If tested in isolation from other Shims, the standard jar layout can be used Signed-off-by: Gera Shegalov <gera@apache.org>
|
build |
|
would be great to test on cdh |
tgravescs
approved these changes
Sep 15, 2021
|
13:53:59 An unexpected error has occurred: CalledProcessError: command: ('/usr/bin/git', 'fetch', 'origin', '--tags') |
|
build |
|
14:00:13 stderr: fatal: unable to access 'https://github.com/NVIDIA/spark-rapids.git/': The requested URL returned error: 429 |
|
build |
|
did not test on CDH yet. will fix in a dedicated PR if it's broken there. |
|
Thanks @abellina for testing on CDH |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #3495
SparkShimServiceProvider
World, then it should follow the same conventions as existing Shims:
the last component in its package name should be the root directory in
the combined rapids-4-spark jar. If tested in isolation from other
Shims, the standard jar layout can be used
Tested with
since we know from the dedupe work that Spark 3.0.x until 3.0.4 can be served with a single shim
Signed-off-by: Gera Shegalov gera@apache.org