Update the scala repl loader to avoid issues with broadcast. #3498
Conversation
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
| // Next we should check for the scala built in REPL interpreter class loader. | ||
| // This happens on the driver side as a part of the REPL. It does not use a | ||
| // MutableURLClassLoader, but has essentially done the same thing. | ||
| Option(contextClassLoader).foreach { loader => |
There was a problem hiding this comment.
LGTM, but I would generalize the pattern matching above and make it another case to avoid have another place to add the same url and pluginClassLoader assingnment.
There was a problem hiding this comment.
I tried it, but it felt less clear and didn't save much. Did you mean you wanted to call addURL by reflection all of the time?
There was a problem hiding this comment.
along these lines, unconditional by reflection was not my initial idea but I think it's reasonable here and will make the code even simpler.
There was a problem hiding this comment.
I tried and I ran into a few issues with using reflection for both paths. I don't really feel like spending more time to debug something that works just to save a few lines of code. So if you are okay with it I think I will just keep it as is.
This fixes #3482