Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GpuSum type to match resultType #3500

Merged
merged 2 commits into from
Sep 16, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,9 @@ case class GpuSum(child: Expression, resultType: DataType)

override lazy val inputProjection: Seq[Expression] = Seq(child)
override lazy val updateExpressions: Seq[Expression] = Seq(new CudfSum(cudfSum))
// we need to cast to `resultType` here, since Spark is not widening types
// as done before Spark 3.2.0. See CudfSum for more info.
override lazy val preUpdate: Seq[Expression] = Seq(GpuCast(cudfSum, resultType))
override lazy val mergeExpressions: Seq[Expression] = Seq(new CudfSum(cudfSum))
override lazy val evaluateExpression: Expression = cudfSum

Expand Down