Auto-dedupe ASM-relocated shim dependencies #3565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Remove the spark version classifier from the package name and just com.nvidia.spark.shaded for ASM-based relocation 2. Remove com/nvidia/spark/shaded from unshimmed classes 3. As a result they get auto-deduped in spark3xx-common For minimumFeatureVersionMix profile consisting of - spark302 - spark311cdh - spark312 - spark320 the jar size goes down from 29M to 17M after compression Pre-compression breakdown ``` $ du -h -s dist/target/parallel-world/spark*/com/nvidia/shaded 372K dist/target/parallel-world/spark302/com/nvidia/shaded 372K dist/target/parallel-world/spark311cdh/com/nvidia/shaded 372K dist/target/parallel-world/spark312/com/nvidia/shaded 372K dist/target/parallel-world/spark320/com/nvidia/shaded 15M dist/target/parallel-world/spark3xx-common/com/nvidia/shade ``` Instead of storing 15M per shim we end up storing 312K delta per shim This will only improve once we have commons per FEATURE versions lines: 3.0.x, 3.1.x, 3.2.x Signed-off-by: Gera Shegalov <gera@apache.org>
gerashegalov
requested review from
GaryShen2008,
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
|
build |
revans2
approved these changes
Sep 21, 2021
jlowe
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
com.nvidia.spark.shaded for ASM-based relocation
For minimumFeatureVersionMix profile consisting of
the jar size goes down from 29M to 17M after compression
Pre-compression breakdown
Instead of storing 15M per shim we end up storing 312K delta per shim
This will only improve once we have commons per FEATURE versions lines:
3.0.x, 3.1.x, 3.2.x
Signed-off-by: Gera Shegalov gera@apache.org