Revert shared class list modifications in PR#3545 #3587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NVIDIA#3580 Classes in unshimmed-common-from-spark301.txt should be bitwise identical but this is assumption is violated by the fact that ProxyRapidsShuffleInternalManagerBase inhertis from Spark's ShuffleManager affecting the bytecode generated by the compiler. The root cause of the bug will be addressed in follow up PRs. Signed-off-by: Gera Shegalov <gera@apache.org>
gerashegalov
requested review from
GaryShen2008,
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
|
build |
tgravescs
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3580
Classes in unshimmed-common-from-spark301.txt should be bitwise
identical to the same named class files in other shim jars such as spark320. However, this is assumption is violated by the fact that
ProxyRapidsShuffleInternalManagerBase inhertis from Spark's
ShuffleManager affecting the bytecode generated by the compiler.
The root cause of the bug will be addressed in follow up PRs.
Signed-off-by: Gera Shegalov gera@apache.org