Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the overflow check algorithm for Subtract #3595

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

firestarman
Copy link
Collaborator

@firestarman firestarman commented Sep 22, 2021

The new algorithm is copied from the openJDK version, which looks simpler and probably gets better performance.

Signed-off-by: Firestarman firestarmanllc@gmail.com

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
@firestarman
Copy link
Collaborator Author

build

Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up

@revans2 revans2 merged commit 6eb74c2 into NVIDIA:branch-21.10 Sep 22, 2021
@firestarman firestarman deleted the overflow-sub branch September 23, 2021 02:18
@pxLi pxLi added the improve label Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants