-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to ucx 1.11.2 for 21.10 #3729
Update to ucx 1.11.2 for 21.10 #3729
Conversation
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
build |
I am not seeing ucx specific issues in the builds/benchmarks we have executed with 1.11.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me with a small suggestion for consistency.
jenkins/Dockerfile-blossom.ubuntu
Outdated
@@ -25,7 +25,7 @@ | |||
|
|||
ARG CUDA_VER=11.0 | |||
ARG UBUNTU_VER=18.04 | |||
ARG UCX_VER=v1.11.0 | |||
ARG UCX_VER=v1.11.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be updated to not require the leading v
to be consistent with the other Docker examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can do that.
build |
Signed-off-by: Alessandro Bellina abellina@nvidia.com
UCX 1.11.2 was just released and it addresses the issues outlined in #3651. I have been running with it and not finding issues. This updates the docs and fetches it for pre_merge. I am updating 1 more job manually tomorrow, so I'll leave this as draft until I run that.
Closes #3651