Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ucx 1.11.2 for 21.10 #3729

Merged
merged 2 commits into from
Oct 2, 2021

Conversation

abellina
Copy link
Collaborator

@abellina abellina commented Oct 1, 2021

Signed-off-by: Alessandro Bellina abellina@nvidia.com

UCX 1.11.2 was just released and it addresses the issues outlined in #3651. I have been running with it and not finding issues. This updates the docs and fetches it for pre_merge. I am updating 1 more job manually tomorrow, so I'll leave this as draft until I run that.

Closes #3651

Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
@sameerz sameerz added the documentation Improvements or additions to documentation label Oct 1, 2021
@sameerz sameerz added this to the Sep 27 - Oct 1 milestone Oct 1, 2021
@abellina
Copy link
Collaborator Author

abellina commented Oct 1, 2021

build

@abellina abellina marked this pull request as ready for review October 1, 2021 21:47
@abellina
Copy link
Collaborator Author

abellina commented Oct 1, 2021

I am not seeing ucx specific issues in the builds/benchmarks we have executed with 1.11.2

jlowe
jlowe previously approved these changes Oct 1, 2021
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me with a small suggestion for consistency.

@@ -25,7 +25,7 @@

ARG CUDA_VER=11.0
ARG UBUNTU_VER=18.04
ARG UCX_VER=v1.11.0
ARG UCX_VER=v1.11.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be updated to not require the leading v to be consistent with the other Docker examples?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can do that.

@abellina
Copy link
Collaborator Author

abellina commented Oct 1, 2021

build

@abellina abellina merged commit 86c990c into NVIDIA:branch-21.10 Oct 2, 2021
@abellina abellina deleted the ucx/update_docs_for_21.10 branch October 2, 2021 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Point users to UCX 1.11.2
4 participants