Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix squashed merge from #3725 #3734

Merged
merged 4 commits into from
Oct 1, 2021
Merged

Fix squashed merge from #3725 #3734

merged 4 commits into from
Oct 1, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Oct 1, 2021

** NOTE: This needs to be merged with a merge commit, not squashed! **

This reverts the squashed merge commit from #3725 and re-merges from branch-21.10 to restore the history.

jlowe and others added 4 commits September 30, 2021 16:27
…#3691)

* Fix issues with AQE and DPP enabled on Spark 3.2

Signed-off-by: Jason Lowe <jlowe@nvidia.com>

* Add canonicalized parameter for 301db shim

* Fix double-close when batch contains multiple columns

* Fix HostColumnVector deserialization
)

fixes NVIDIA#3718

Evidently some jars were removed from the cdh maven repo that were pulled in through spark-hive -> spark-core -> curator-recipes.  We don't use that version as its explicitly called out in the cdh profiles.  Just exclude spark-core when pulling in spark-hive dep.  Built and unit tests pass.

I did see a couple of other dependency warnings but then didn't see them again. I'll rerun with clean m2 but that shouldn't block this to fix the build.

For reference the error was:
`Could not resolve dependencies for project com.nvidia:rapids-4-spark-sql_2.12:jar:21.10.0-SNAPSHOT: Failed to collect dependencies at org.apache.spark:spark-hive_2.12:jar:3.1.1.3.1.7270.0-253 -> org.apache.spark:spark-core_2.12:jar:3.1.1.3.1.7270.0-253 -> org.apache.curator:curator-recipes:jar:4.3.0.7.2.7.0-SNAPSHOT: Failed to read artifact descriptor for org.apache.curator:curator-recipes:jar:4.3.0.7.2.7.0-SNAPSHOT: Could not transfer artifact org.apache.curator:curator-recipes:pom:4.3.0.7.2.7.0-SNAPSHOT from/to cloudera (https://repo.hortonworks.com/nexus/content/groups/public): PKIX path building failed:`

Signed-off-by: Thomas Graves <tgraves@nvidia.com>
@jlowe jlowe added the build Related to CI / CD or cleanly building label Oct 1, 2021
@jlowe jlowe self-assigned this Oct 1, 2021
@jlowe
Copy link
Member Author

jlowe commented Oct 1, 2021

Skipping CI since there's no code change and run was clean from #3725.

@jlowe jlowe merged commit 3273c81 into NVIDIA:branch-21.12 Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants