Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce usage of escaping in xargs #3795

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Reduce usage of escaping in xargs #3795

merged 1 commit into from
Oct 12, 2021

Conversation

gerashegalov
Copy link
Collaborator

  • use exported functions instead

potentially fixes #3769, #3783

Signed-off-by: Gera Shegalov gera@apache.org

@gerashegalov
Reduce usage of escaping in xargs
31229d0 
- use exported functions instead

Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov gerashegalov added bug Something isn't working build Related to CI / CD or cleanly building labels Oct 12, 2021
@gerashegalov gerashegalov added this to the Oct 4 - Oct 15 milestone Oct 12, 2021
@gerashegalov gerashegalov self-assigned this Oct 12, 2021
@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov gerashegalov linked an issue Oct 12, 2021 that may be closed by this pull request
[BUG] spark-rapids v21.10.0 release build failed on script "dist/scripts/binary-dedupe.sh" #3783
Closed
@pxLi
Copy link
Collaborator

pxLi commented Oct 12, 2021 •
edited
Loading

does this need to be targeted to branch-21.10?

@gerashegalov
Copy link
Collaborator Author

gerashegalov commented Oct 12, 2021 •
edited
Loading

does this need to be targeted to branch-21.10?

only if it helps with #3783 that your team filed @pxLi

@pxLi
Copy link
Collaborator

pxLi commented Oct 12, 2021 •
edited by gerashegalov
Loading

does this need to be targeted to branch-21.10?

only if it helps with #3783 that your team filed @pxLi

cc @NvTimLiu CMIW I think the issue is targeted to 21.10, and it may block our incoming release

@tgravescs
Copy link
Collaborator

yes let retarget for 21.10 as it appears to fix the issue, we tested on the release build, we also seeing failures in other builds.

@gerashegalov gerashegalov changed the base branch from branch-21.12 to branch-21.10 October 12, 2021 18:36
@gerashegalov gerashegalov merged commit 877fbd9 into NVIDIA:branch-21.10 Oct 12, 2021
@gerashegalov gerashegalov deleted the avoidEscaping branch October 12, 2021 20:41
abellina pushed a commit to abellina/spark-rapids that referenced this pull request Oct 13, 2021
@gerashegalov @abellina
Reduce usage of escaping in xargs (NVIDIA#3795)
7b0dcb4 
Use exported functions in xargs instead of longer commands with escaped characters.

Signed-off-by: Gera Shegalov <gera@apache.org>
@NvTimLiu NvTimLiu mentioned this pull request Oct 13, 2021
Closed
@gerashegalov gerashegalov mentioned this pull request Oct 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgravescs tgravescs tgravescs approved these changes

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu

Assignees

@gerashegalov gerashegalov

Labels
bug Something isn't working build Related to CI / CD or cleanly building
Projects
None yet
Milestone
Oct 4 - Oct 15
3 participants
@gerashegalov @pxLi @tgravescs