Optimize out bounds checking for joins when the gather map has only valid entries #3799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abellina
changed the title
valid entries Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
abellina
force-pushed
the
perf/bounds_checker
branch
from
f483226 to
44f4b09
Compare
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3798
This PR implements an optimization to not check for bounds when gathering rows from a gather map during joins, for certain types of joins as described in the linked issue.
Overall I see q72 improve around 40 seconds or 12%-19% from the run times we see in spark2a. The overall time for all queries summed is ~ 1 minute less or around 5% improvement overall. There is some noise in the numbers but nothing below 80% on single-digit second queries, so I am not seeing a regression and seems like normal system noise, but we need to quantify this part better.