Correct 21.10 docs such as PCBS related FAQ [skip ci] #3815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct some doc for 21.10
sameerz
requested changes
Oct 14, 2021
pxLi
changed the title
Add 21.10 release notes
sameerz
requested changes
Oct 14, 2021
Add more release notes for 21.10
sameerz
reviewed
Oct 14, 2021
Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
sameerz
previously approved these changes
Oct 14, 2021
ttnghia
reviewed
Oct 14, 2021
Co-authored-by: Nghia Truong <ttnghia@users.noreply.github.com>
abellina
reviewed
Oct 14, 2021
| @@ -287,13 +287,15 @@ AdaptiveSparkPlan isFinalPlan=false | |||
|
|
|||
| ### Are cache and persist supported? | |||
|
|
|||
| Yes cache and persist are supported, but they are not GPU accelerated yet. We are working with | |||
| the Spark community on changes that would allow us to accelerate compression when caching data. | |||
| Yes cache and persist are supported, the cache is GPU accelerated | |||
There was a problem hiding this comment.
indentation is a little off here.
There was a problem hiding this comment.
@abellina i think the indentation is correct, right? I mean the indentation before "Yes" looks good to me.
There was a problem hiding this comment.
+1 to what @sameerz said. It's a minor nit, but it is an odd break in this line.
sameerz
reviewed
Oct 15, 2021
Comment on lines
+290
to
+293
| Yes cache and persist are supported, the cache is GPU accelerated | ||
| but still stored on the host memory. | ||
| Please refer to [RAPIDS Cache Serializer](./additional-functionality/cache-serializer.md) | ||
| for more details. |
There was a problem hiding this comment.
@viadea I think abellina means the indenting for the text in the editor. Try the following:
Suggested change
| Yes cache and persist are supported, the cache is GPU accelerated | |
| but still stored on the host memory. | |
| Please refer to [RAPIDS Cache Serializer](./additional-functionality/cache-serializer.md) | |
| for more details. | |
| Yes cache and persist are supported, the cache is GPU accelerated but still stored on the host | |
| memory. Please refer to [RAPIDS Cache Serializer](./additional-functionality/cache-serializer.md) | |
| for more details.``` |
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct some doc for 21.10