-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent approx_percentile aggregate from being split between CPU and GPU #3862
Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ae86e6d
Implement fix and basic test
andygrove 5321446
improve test based on PR feedback
andygrove a2b96e1
check tags more consistently
andygrove e0229e6
Add test that does not depend on CAST of array falling back to CPU
andygrove e91bab1
add license header
andygrove 8480729
simplify test to use spark.rapids.sql.hashAgg.replaceMode
andygrove 3743bfa
Update comments
andygrove eb864f9
revert plugin changes
andygrove 74edef1
fix some regressions
andygrove 96e52a6
WIP temporarily allow ObjectHashAggregate/SortAggregate/Sort to allow…
andygrove 3ca8c75
scalastyle
andygrove 8689bf0
add placeholders for BinaryType checks
andygrove 30d075a
Merge remote-tracking branch 'nvidia/branch-21.12' into issue-3834
andygrove 36a43aa
ps notes and type checks
andygrove ff500a1
enable more tests
andygrove 1413059
remove redundant and untested type check
andygrove b183cdf
add test for sort fallback to cpu with binary input
andygrove a82d6ef
test for SortExec with BinaryType
andygrove 245aaf6
revert changes to aggregate.scala
andygrove f8ef03e
remove ps note for SortExec BinaryType
andygrove abce3d1
Merge remote-tracking branch 'nvidia/branch-21.12' into issue-3834
andygrove File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this test work in a similar way to the
assert_cpu_and_gpu_are_equal_collect_with_capture
, where a list of "exist" and "non_exist" classes are used to assert that the query has indeed fallen back.Thinking of the case if the cast gets "pushed up" to a projection after the hash agg in the future.