Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace long artifact lists with an ant loop #3976

Merged
merged 3 commits into from
Nov 1, 2021
Merged

Replace long artifact lists with an ant loop #3976

merged 3 commits into from
Nov 1, 2021

Conversation

gerashegalov
Copy link
Collaborator

  • Replaces copy-current executions with a single-line inside the for loop in ant
  • Factors the common aggregator dependency out of all profiles

Closes #3975

Signed-off-by: Gera Shegalov gera@apache.org

@gerashegalov
Move dependency:copy to the antrun for loop
b5fdd1b 
Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov
Replace long artifact lists with an ant loop
292661c 
Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov gerashegalov self-assigned this Oct 31, 2021
@gerashegalov gerashegalov added audit General label for audit related tasks task Work required that improves the product but is not user facing build Related to CI / CD or cleanly building and removed audit General label for audit related tasks labels Oct 31, 2021
@gerashegalov gerashegalov added this to the Nov 1 - Nov 12 milestone Oct 31, 2021
@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov gerashegalov merged commit 1bb88d2 into NVIDIA:branch-21.12 Nov 1, 2021
@gerashegalov gerashegalov deleted the loopDepCopy branch November 1, 2021 15:59
@pxLi pxLi mentioned this pull request Nov 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgravescs tgravescs tgravescs approved these changes

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@jlowe jlowe Awaiting requested review from jlowe jlowe is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

Assignees

@gerashegalov gerashegalov

Labels
build Related to CI / CD or cleanly building task Work required that improves the product but is not user facing
Projects
None yet
Milestone
Nov 1 - Nov 12
Development

Successfully merging this pull request may close these issues.

[FEA] Roll explicit dependency:copy into a loop in dist/pom.xml
2 participants
@gerashegalov @tgravescs