Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use install for the base version build thread [skip ci] #4054

Merged

Conversation

gerashegalov
Copy link
Collaborator

Make sure that the minimum spark version classifier of the aggregator (typically 301) is installed

Closes #4053

Signed-off-by: Gera Shegalov gera@apache.org

Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov gerashegalov requested a review from revans2 November 8, 2021 18:06
@gerashegalov gerashegalov self-assigned this Nov 8, 2021
@gerashegalov gerashegalov added bug Something isn't working build Related to CI / CD or cleanly building labels Nov 8, 2021
@gerashegalov gerashegalov added this to the Nov 1 - Nov 12 milestone Nov 8, 2021
revans2
revans2 previously approved these changes Nov 8, 2021
@tgravescs
Copy link
Collaborator

does https://github.com/NVIDIA/spark-rapids/blob/branch-21.12/CONTRIBUTING.md need to be updated, we don't say anything about install?

Signed-off-by: Gera Shegalov <gera@apache.org>
@tgravescs
Copy link
Collaborator

build

@tgravescs tgravescs changed the title Use install for the base version build thread Use install for the base version build thread [skip ci] Nov 8, 2021
@tgravescs
Copy link
Collaborator

build

@tgravescs
Copy link
Collaborator

tgravescs commented Nov 8, 2021

none of this is tested by pre-merge build so added skip ci

@gerashegalov gerashegalov merged commit 35a216c into NVIDIA:branch-21.12 Nov 8, 2021
@gerashegalov gerashegalov deleted the gerashegalov/issue4053 branch November 8, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] buildall uses a stale aggregator dependency during test compilation
3 participants