Support building from sub directory #4070
Conversation
Signed-off-by: Chong Gao <res_life@163.com>
res-life
requested review from
GaryShen2008,
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
|
build |
| @@ -214,7 +214,6 @@ | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-antrun-plugin</artifactId> | |||
| <version>1.8</version> | |||
There was a problem hiding this comment.
Root pom is 3.0.0, but here it's 1.8, so delete this line.
|
Use directory-maven-plugin to get spark-rapids root path instead of user.dir which is a relative path. |
There was a problem hiding this comment.
I agree this looks good to me, but I really would like to hear from @gerashegalov about this because he has been doing most of the work on the maven build system lately.
| @@ -48,7 +48,7 @@ | |||
| <target> | |||
| <mkdir dir="${project.build.directory}/extra-resources"/> | |||
| <exec executable="bash" failonerror="true" output="${project.build.directory}/extra-resources/spark-${spark301.version}-info.properties"> | |||
There was a problem hiding this comment.
In a follow-on we need to generalize this invocation to use spark.version and move to the shim/pom.xml and delete from child shims.
Use directory-maven-plugin to get spark-rapids root path instead of user.dir which is a relative path.
Fixes #3461
Signed-off-by: Chong Gao res_life@163.com