-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support row-based Hive UDFs [databricks] #4224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Mark as draft, because needing to try an external app next. |
build |
firestarman
changed the title
Support row-based Hive UDFs
Support row-based Hive UDFs [databricks]
Nov 29, 2021
This UDF is an interface, so the only way is to suppress the warning. Signed-off-by: Firestarman <firestarmanllc@gmail.com>
build |
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
build |
1 similar comment
build |
build |
jlowe
reviewed
Nov 29, 2021
firestarman
requested review from
GaryShen2008,
NvTimLiu,
revans2 and
tgravescs
as code owners
November 29, 2021 23:15
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
build |
jlowe
reviewed
Nov 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion on willNotWork wording but otherwise lgtm.
sql-plugin/src/main/scala/org/apache/spark/sql/hive/rapids/GpuHiveOverrides.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/hive/rapids/GpuHiveOverrides.scala
Outdated
Show resolved
Hide resolved
…HiveOverrides.scala Update the willNotWork wording. Co-authored-by: Jason Lowe <jlowe@nvidia.com>
…HiveOverrides.scala Update the willNotWork wording for Hive GenericUDF. Co-authored-by: Jason Lowe <jlowe@nvidia.com>
build |
jlowe
approved these changes
Dec 1, 2021
build |
1 similar comment
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3904
Signed-off-by: Firestarman firestarmanllc@gmail.com