Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in parsing regex character classes that start with ^ and contain an unescaped ] #4241

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

andygrove
Copy link
Contributor

Signed-off-by: Andy Grove andygrove@nvidia.com

This bug was exposed by one of the existing fuzzer tests in another issue I was working on.

…ntain an unescaped `]`

Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove andygrove added the bug Something isn't working label Nov 30, 2021
@andygrove andygrove added this to the Nov 30 - Dec 10 milestone Nov 30, 2021
@andygrove andygrove self-assigned this Nov 30, 2021
@jlowe
Copy link
Member

jlowe commented Nov 30, 2021

build

@andygrove
Copy link
Contributor Author

build failed with

 [2021-11-30T23:59:20.320Z] - Cast from string to float using hand-picked values *** FAILED ***
[2021-11-30T23:59:20.320Z]   Mismatch casting string [+nAn] to FloatType. CPU: null; GPU: NaN (CastOpSuite.scala:258)

@andygrove
Copy link
Contributor Author

build

@andygrove andygrove merged commit 1d961d3 into NVIDIA:branch-22.02 Dec 2, 2021
@andygrove andygrove deleted the regex-char-class-fix branch December 2, 2021 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants