Update the release script [skip ci] #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Argument for the spark version of the final build and aggregation Signed-off-by: Tim Liu <timl@nvidia.com>
NvTimLiu
requested review from
gerashegalov,
tgravescs,
firestarman,
pxLi and
GaryShen2008
NvTimLiu
commented
Dec 1, 2021
| @@ -82,15 +83,15 @@ $DEPLOY_CMD -Durl=$SERVER_URL -DrepositoryId=$SERVER_ID \ | |||
| # Distribution jar is a shaded artifact so use the reduced dependency pom. | |||
| $DEPLOY_CMD -Durl=$SERVER_URL -DrepositoryId=$SERVER_ID \ | |||
| $SRC_DOC_JARS \ | |||
| -Dfile=$FPATH.jar -DgroupId=com.nvidia -DartifactId=$ART_ID -Dversion=$ART_VER -DpomFile=./dist/target/dependency-reduced-pom.xml | |||
There was a problem hiding this comment.
We removed the depednecy-reduce script from dist pom.xml from branch-21.12, so not such ./dist/target/dependency-reduced-pom.xml will be generated.
tgravescs
reviewed
Dec 1, 2021
| ###### Choose the deploy command ###### | ||
|
|
||
| if [ "$SIGN_FILE" == true ]; then | ||
| # No javadoc and sources jar is generated for shade artifact only. Use 'sql-plugin' instead | ||
| SQL_ART_ID=`mvn help:evaluate -q -pl $SQL_PL -Dexpression=project.artifactId -DforceStdout` | ||
| SQL_ART_VER=`mvn help:evaluate -q -pl $SQL_PL -Dexpression=project.version -DforceStdout` | ||
| JS_FPATH="${SQL_PL}/target/${SQL_ART_ID}-${SQL_ART_VER}" | ||
| JS_FPATH="${SQL_PL}/target/spark${FINAL_AGG_VERSION_TOBUILD}/${SQL_ART_ID}-${SQL_ART_VER}" | ||
| SRC_DOC_JARS="-Dsources=${JS_FPATH}-sources.jar -Djavadoc=${JS_FPATH}-javadoc.jar" |
There was a problem hiding this comment.
I never realized we were doing this, it works but techinically not correct. I'll file a separate issue for that though to see if we want to handle differently.
tgravescs
approved these changes
Dec 1, 2021
|
build |
NvTimLiu
commented
Dec 1, 2021
| ###### Choose the deploy command ###### | ||
|
|
||
| if [ "$SIGN_FILE" == true ]; then | ||
| # No javadoc and sources jar is generated for shade artifact only. Use 'sql-plugin' instead | ||
| SQL_ART_ID=`mvn help:evaluate -q -pl $SQL_PL -Dexpression=project.artifactId -DforceStdout` | ||
| SQL_ART_VER=`mvn help:evaluate -q -pl $SQL_PL -Dexpression=project.version -DforceStdout` | ||
| JS_FPATH="${SQL_PL}/target/${SQL_ART_ID}-${SQL_ART_VER}" | ||
| JS_FPATH="${SQL_PL}/target/spark${FINAL_AGG_VERSION_TOBUILD}/${SQL_ART_ID}-${SQL_ART_VER}" |
There was a problem hiding this comment.
we append spark version to the target path since branch-21.12.
res-life
pushed a commit
to res-life/spark-rapids
that referenced
this pull request
Dec 6, 2021
Argument for the spark version of the final build and aggregation Signed-off-by: Tim Liu <timl@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argument for the spark version of the final build and aggregation
Signed-off-by: Tim Liu timl@nvidia.com