fix regression in cast from string to float that caused signed NaN to be considered valid #4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be valid Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
jlowe
approved these changes
Dec 2, 2021
revans2
approved these changes
Dec 2, 2021
res-life
pushed a commit
to res-life/spark-rapids
that referenced
this pull request
Dec 6, 2021
… be valid (NVIDIA#4259) Signed-off-by: Andy Grove <andygrove@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Grove andygrove@nvidia.com
Closes #4246
Changes in this PR:
NaNandInf(case insensitive, supports+and-, supports bothInfandInfinity)VALID_FLOAT_REGEXto reject signed NaN values (+NaN,-NaN) which are now supported by cuDF but not by Spark