Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print meaningful message when calling scripts in maven #4327

Merged
merged 5 commits into from
Dec 15, 2021

Conversation

res-life
Copy link
Collaborator

@res-life res-life commented Dec 8, 2021

Print the error message when calling scripts in maven.
Add resultproperty and errorproperty to save the errorMsg and the exitCode, and then check.
This fixes #4292

Signed-off-by: Chong Gao res_life@163.com

Signed-off-by: Chong Gao <res_life@163.com>
@res-life
Copy link
Collaborator Author

res-life commented Dec 8, 2021

build

@res-life
Copy link
Collaborator Author

res-life commented Dec 8, 2021

@gerashegalov
Because the Linux time command prints to stderr by default, the error info includes time spent info.

[ERROR] /home/chong/code/spark-rapids/dist/maven-antrun/build-parallel-worlds.xml:131: exec binary-dedupe.sh failed 
......
[ERROR] 
[ERROR] real	0m0.011s
[ERROR] user	0m0.008s
[ERROR] sys	0m0.005s
[ERROR] com/nvidia/spark/ExclusiveModeGpuDiscoveryPlugin.class is not bitwise-identical across shims

@gerashegalov
Copy link
Collaborator

@gerashegalov Because the Linux time command prints to stderr by default, the error info includes time spent info.

[ERROR] /home/chong/code/spark-rapids/dist/maven-antrun/build-parallel-worlds.xml:131: exec binary-dedupe.sh failed 
......
[ERROR] 
[ERROR] real	0m0.011s
[ERROR] user	0m0.008s
[ERROR] sys	0m0.005s
[ERROR] com/nvidia/spark/ExclusiveModeGpuDiscoveryPlugin.class is not bitwise-identical across shims

I added these times for diagnostics when we found that binary-dedupe was really slow on macOS but this is now mostly resolved and probably should not be logged to console. Feel free to either remove time wrappers or add --append --output=<file> to log timing info to a file.

Chong Gao added 2 commits December 9, 2021 11:51
Signed-off-by: Chong Gao <res_life@163.com>
Signed-off-by: Chong Gao <res_life@163.com>
@res-life
Copy link
Collaborator Author

res-life commented Dec 9, 2021

  1. Removed time wrappers because the total time is printed.
[exec] binary-dedupe completed in 19 seconds
  1. Added the exit code as part of the message.
  2. Reordered the binary-dedupe.sh and check-shims-revisions.sh in the build-parallel-worlds.xml.

@res-life
Copy link
Collaborator Author

res-life commented Dec 9, 2021

build

@sameerz sameerz added the task Work required that improves the product but is not user facing label Dec 10, 2021
Chong Gao added 2 commits December 13, 2021 15:10
Signed-off-by: Chong Gao <res_life@163.com>
@res-life
Copy link
Collaborator Author

build

Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@NvTimLiu NvTimLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@res-life res-life merged commit 7b28aa9 into NVIDIA:branch-22.02 Dec 15, 2021
@res-life res-life deleted the meaningful-msg branch December 15, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Work required that improves the product but is not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] no meaningful message is surfaced to maven when binary-dedupe fails
4 participants