Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable add profile src execution by default to make the build log clean #4435

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Disable add profile src execution by default to make the build log clean #4435

merged 1 commit into from
Jan 5, 2022

Conversation

res-life
Copy link
Collaborator

Signed-off-by: Chong Gao res_life@163.com

@res-life
Copy link
Collaborator Author

This is to remove lots of the following prints

[INFO] --- build-helper-maven-plugin:3.2.0:add-source (add-profile-src-30+) @ rapids-4-spark-api-validation ---
[INFO] Source directory: /home/chong/code/spark-rapids/api_validation/src/main/301+-nondb/scala added.
[INFO] Source directory: /home/chong/code/spark-rapids/api_validation/src/main/301until310-all/scala added.
[INFO] Source directory: /home/chong/code/spark-rapids/api_validation/src/main/301until310-nondb/scala added.
[INFO] Source directory: /home/chong/code/spark-rapids/api_validation/src/main/301until320-all/scala added.
[INFO] Source directory: /home/chong/code/spark-rapids/api_validation/src/main/301until320-nondb/scala added.
[INFO] Source directory: /home/chong/code/spark-rapids/api_validation/src/main/301until330-all/scala added.
[INFO] Source directory: /home/chong/code/spark-rapids/api_validation/src/main/pre320-treenode/scala added.

@res-life
Copy link
Collaborator Author

build

firestarman
firestarman reviewed Dec 29, 2021
View reviewed changes
pom.xml
@@ -663,7 +663,7 @@
<execution>
<id>add-profile-src-31+</id>
<goals><goal>add-source</goal></goals>
<phase>generate-sources</phase>
<phase>none</phase> <!--Disable it for all submodules, only sql-plugin needs to enable it -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about removing this whole execution if it was not needed ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. But not sure if submodules will use this in future.
Let's keep it in the parent pom.

@sameerz sameerz added the build Related to CI / CD or cleanly building label Dec 29, 2021
gerashegalov
gerashegalov approved these changes Dec 30, 2021
View reviewed changes
Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In a future PR, it would also be great to get rid of duplicate definitions of executions like add-profile-src-30+ identical across profiles

@res-life
Copy link
Collaborator Author

res-life commented Jan 4, 2022

build

1 similar comment
@res-life
Copy link
Collaborator Author

res-life commented Jan 4, 2022

build

@res-life res-life merged commit 731b5f5 into NVIDIA:branch-22.02 Jan 5, 2022
@res-life res-life deleted the disable-add-profile-src branch January 5, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firestarman firestarman firestarman left review comments

@revans2 revans2 revans2 approved these changes

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@jlowe jlowe Awaiting requested review from jlowe jlowe is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs is a code owner

@gerashegalov gerashegalov Awaiting requested review from gerashegalov

Assignees
No one assigned
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@res-life @gerashegalov @revans2 @firestarman @sameerz