[WIP] Fix broken build and rework shims after SPARK-37705 for Spark 3.3.0 #4444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kuhu Shukla <kuhus@nvidia.com>
kuhushukla
force-pushed
the
shim_330_parquet
branch
from
f14fa18 to
2706876
Compare
|
We have a full fix here #4447. Yes it is a little big, but to pass the premerge. |
|
Closing as superceded by #4447. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4443
I wanted to use polymorphism for
getParquetFiltersbut it gets quite hairy on the ScanBase side of things so I had to make it more generic in addition to adding new shim folders to generate sources correctly. I could use any and all comments on how to improve this.Note that for 3.3.0 build, SPARK-35703 is still blocking compile so this change will show less compile errors as it fixes the one from the parquet issue alone.