Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libcudf mixed joins for conditional hash joins [databricks] #4477

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Jan 7, 2022

Related to #2441. Depends on rapidsai/cudf#9941.

This implements GPU support for LeftOuter, RightOuter, FullOuter, and Inner joins using libcudf's mixed join feature. As before, inner joins will fallback to a post-filter approach for the condition if the condition cannot be expressed as a cudf AST.

@jlowe jlowe added the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Jan 7, 2022
@jlowe jlowe added this to the Jan 10 - Jan 28 milestone Jan 7, 2022
@jlowe jlowe self-assigned this Jan 7, 2022
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
Copy link
Contributor

@jbrennan333 jbrennan333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 this looks good to me.

@jlowe jlowe added the performance A performance related task/issue label Jan 13, 2022
@jlowe jlowe marked this pull request as ready for review January 19, 2022 19:09
@jlowe
Copy link
Member Author

jlowe commented Jan 19, 2022

cudf dependency has been merged and published, so this should be ready to go.

@jlowe
Copy link
Member Author

jlowe commented Jan 19, 2022

build

Copy link
Contributor

@jbrennan333 jbrennan333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf performance A performance related task/issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants