Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove scala-library from combined tools jar #4566

Merged
merged 3 commits into from
Jan 19, 2022
Merged

remove scala-library from combined tools jar #4566

merged 3 commits into from
Jan 19, 2022

Conversation

tgravescs
Copy link
Collaborator

Fixes #4454

build was reporting a shade warnings when building the tools artifact

[WARNING] rapids-4-spark-tools_2.12-22.02.0-SNAPSHOT.jar, scala-library-2.12.15.jar define 1 overlapping resource: 
[WARNING]   - META-INF/MANIFEST.MF
[WARNING] maven-shade-plugin has detected that some class files are

I did some testing and it doesn't look like we need to include the scala-library in the combined tools jar. For the tools the user has to include the jars directory for Spark so we can pick up the scala library from there. I tested against a bunch of different spark versions from 3.0.1 and up and it ran fine.

@tgravescs tgravescs added the build Related to CI / CD or cleanly building label Jan 19, 2022
@tgravescs tgravescs added this to the Jan 10 - Jan 28 milestone Jan 19, 2022
@tgravescs tgravescs self-assigned this Jan 19, 2022
@tgravescs
sign off
0278a3c 
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
@tgravescs
Copy link
Collaborator Author

build

@tgravescs tgravescs merged commit de76134 into NVIDIA:branch-22.02 Jan 19, 2022
@tgravescs tgravescs deleted the toolswarning branch January 19, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

Assignees

@tgravescs tgravescs

Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
Jan 10 - Jan 28
Development

Successfully merging this pull request may close these issues.

[BUG] Shade warnings when building the tools artifact
2 participants
@tgravescs @jlowe