-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove shims module [databricks] #4629
Conversation
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
build |
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
build |
...main/shim301/scala/com/nvidia/spark/rapids/shims/spark301/RapidsShuffleInternalManager.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
.../shim301db/scala/com/nvidia/spark/rapids/shims/spark301db/RapidsShuffleInternalManager.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
build |
...src/main/303/scala/com/nvidia/spark/rapids/shims/spark303/RapidsShuffleInternalManager.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
build |
CI failed due to Are we missing some jars for 22.04 for db? |
nope, the rapids-4-spark-shims-spark301db&rapids-4-spark-shims-spark312db_2.12 was supposed be built with in this CI (but this PR remove the 301db and 312db shims), and we never deploy nightly shims to sonatype snapshot repo. failed at FYI for pre-merge, since we have old nightly snapshot of shims on URM, so test in blossom could pass the build (which is not correct actually). And on DB runtime, it correctly failed as no those deps available. |
Ah, right, I totally missed in the review that a number of other poms (aggregator, tests, etc.) need to be updated, as they explicitly depend on the shims artifact being removed. @razajafri you can build in a clean repo, either by cleaning out your local ~/.m2 or using something like |
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
aah! of course I should've removed the dependency from other modules |
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
build |
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
build |
build |
This is the first commit in a series of commit. The goal is to get rid of v1 shims usage and replace it with v2 usage