Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable 311cdh build by default because of a missing dependency #4659

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

tgravescs
Copy link
Collaborator

The build started to fail to build 311cdh due to missing dependency in their repo:

[2022-01-28T17:38:28.398Z] [ERROR] Failed to execute goal on project rapids-4-spark-sql_2.12: Could not resolve dependencies for project com.nvidia:rapids-4-spark-sql_2.12:jar:22.04.0-SNAPSHOT: Could not find artifact log4j:log4j:jar:1.2.17-cloudera1 in apache-snapshots-repo (https://urm.nvidia.com/artifactory/sw-spark-maven) -> [Help 1]

Since they will change CDH version when they pick up 22.02 we can stop building 311cdh for now.

Disable in the premerge and the nightly and also remove it from the buildall script.

Signed-off-by: Thomas Graves tgraves@nvidia.com

Signed-off-by: Thomas Graves <tgraves@nvidia.com>
@tgravescs tgravescs added the build Related to CI / CD or cleanly building label Jan 28, 2022
@tgravescs tgravescs added this to the Jan 10 - Jan 28 milestone Jan 28, 2022
@tgravescs tgravescs self-assigned this Jan 28, 2022
abellina
abellina previously approved these changes Jan 28, 2022
Copy link
Collaborator

@abellina abellina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abellina
Copy link
Collaborator

build

1 similar comment
@tgravescs
Copy link
Collaborator Author

build

jlowe
jlowe previously approved these changes Jan 28, 2022
@tgravescs tgravescs changed the base branch from branch-22.04 to branch-22.02 January 28, 2022 23:38
@tgravescs tgravescs dismissed stale reviews from jlowe and abellina January 28, 2022 23:38

The base branch was changed.

@tgravescs
Copy link
Collaborator Author

build

@tgravescs tgravescs merged commit ea7c158 into NVIDIA:branch-22.02 Jan 29, 2022
@tgravescs tgravescs deleted the disablecdh branch January 29, 2022 04:18
tgravescs added a commit to tgravescs/spark-rapids that referenced this pull request Jan 31, 2022
This reverts commit ea7c158.

Signed-off-by: Thomas Graves <tgraves@nvidia.com>
tgravescs added a commit to tgravescs/spark-rapids that referenced this pull request Jan 31, 2022
This reverts commit ea7c158.

Signed-off-by: Thomas Graves <tgraves@nvidia.com>
tgravescs added a commit that referenced this pull request Feb 1, 2022
* Revert "Disable 311cdh build due to missing dependency (#4659)"

This reverts commit ea7c158.

Signed-off-by: Thomas Graves <tgraves@nvidia.com>

* leave copyrights

Signed-off-by: Thomas Graves <tgraves@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants