-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable 311cdh build by default because of a missing dependency #4659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
tgravescs
requested review from
GaryShen2008,
jlowe,
NvTimLiu and
revans2
as code owners
January 28, 2022 23:20
abellina
previously approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
build |
1 similar comment
build |
jlowe
previously approved these changes
Jan 28, 2022
tgravescs
dismissed stale reviews from jlowe and abellina
January 28, 2022 23:38
The base branch was changed.
build |
jlowe
approved these changes
Jan 28, 2022
tgravescs
added a commit
to tgravescs/spark-rapids
that referenced
this pull request
Jan 31, 2022
This reverts commit ea7c158. Signed-off-by: Thomas Graves <tgraves@nvidia.com>
tgravescs
added a commit
to tgravescs/spark-rapids
that referenced
this pull request
Jan 31, 2022
This reverts commit ea7c158. Signed-off-by: Thomas Graves <tgraves@nvidia.com>
tgravescs
added a commit
that referenced
this pull request
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build started to fail to build 311cdh due to missing dependency in their repo:
[2022-01-28T17:38:28.398Z] [ERROR] Failed to execute goal on project rapids-4-spark-sql_2.12: Could not resolve dependencies for project com.nvidia:rapids-4-spark-sql_2.12:jar:22.04.0-SNAPSHOT: Could not find artifact log4j:log4j:jar:1.2.17-cloudera1 in apache-snapshots-repo (https://urm.nvidia.com/artifactory/sw-spark-maven) -> [Help 1]
Since they will change CDH version when they pick up 22.02 we can stop building 311cdh for now.
Disable in the premerge and the nightly and also remove it from the buildall script.
Signed-off-by: Thomas Graves tgraves@nvidia.com