Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map_test ANSI failure in Spark 3.3.0 #4690

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

amahussein
Copy link
Collaborator

Fixes #4564

Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me

Spark-330+ throws an SparkNoSuchElementException on failure for map_get.
The tests were failing because prior Spark releases were throwing java.util.NoSuchElementException.

Building on the changes in #4039, the fix is to add shims to specify the correct type of exception for the different releases.

This fix needs to be followed up by the feature request in #4668

Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
@amahussein
Copy link
Collaborator Author

build

@amahussein amahussein self-assigned this Feb 4, 2022
@amahussein amahussein added this to the Jan 31 - Feb 11 milestone Feb 4, 2022
@jlowe
Copy link
Member

jlowe commented Feb 4, 2022

build

Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
@sameerz sameerz added the bug Something isn't working label Feb 4, 2022
@jlowe jlowe changed the title RAPIDS-4564. fix map_test ansi failure in spark330 Fix map_test ANSI failure in Spark 3.3.0 Feb 4, 2022
@jlowe jlowe merged commit 1f22cf0 into NVIDIA:branch-22.04 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] map_test ansi failed in spark330
3 participants