Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to print revision differences when building shims #4871

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

res-life
Copy link
Collaborator

@res-life res-life commented Feb 25, 2022

Minor changes to print revision differences when building shims. Closes #4842

Signed-off-by: Chong Gao res_life@163.com

Signed-off-by: Chong Gao <res_life@163.com>
@res-life res-life self-assigned this Feb 25, 2022
@res-life
Copy link
Collaborator Author

The error info

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:3.0.0:run (create-parallel-world) on project rapids-4-spark_2.12: An Ant BuildException has occured: The following error occurred while executing this line:
[ERROR] /home/chong/code/1-spark-rapids/dist/maven-antrun/build-parallel-worlds.xml:133: exec check-shims-revisions.sh failed, exit code is 1, error msg is Check Failed: git revisions between shims are not equal
[ERROR] Please check the revisions of each shim to see which one is inconsistent. Note, if building with Databricks those jars are built separately.
[ERROR] -------------
[ERROR] Version file /home/chong/code/1-spark-rapids/dist/target/parallel-world/spark321/rapids4spark-version-info.properties, version is d0e14f3ccea06e8e0fba2564b3d6034cdbeafff0
[ERROR] Version file /home/chong/code/1-spark-rapids/dist/target/parallel-world/spark301db/rapids4spark-version-info.properties, version is 159126e09d6d0d4dfe5ff3110bf53340e6d5950d
[ERROR] ------------
[ERROR] around Ant part ...<ant antfile="/home/chong/code/1-spark-rapids/dist/maven-antrun/build-parallel-worlds.xml" target="build-parallel-worlds" />... @ 9:129 in /home/chong/code/1-spark-rapids/dist/target/antrun/build-main.xml

@codecov-commenter
Copy link

Codecov Report

Merging #4871 (d0e14f3) into branch-22.04 (d0e14f3) will not change coverage.
The diff coverage is n/a.

❗ Current head d0e14f3 differs from pull request most recent head 7243c2e. Consider uploading reports for the commit 7243c2e to get more accurate results

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4871   +/-   ##
===============================================
  Coverage           49.48%   49.48%           
  Complexity           1920     1920           
===============================================
  Files                 227      227           
  Lines               23147    23147           
  Branches             4107     4107           
===============================================
  Hits                11455    11455           
  Misses               9705     9705           
  Partials             1987     1987           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0e14f3...7243c2e. Read the comment docs.

@gerashegalov gerashegalov added the build Related to CI / CD or cleanly building label Feb 25, 2022
@gerashegalov
Copy link
Collaborator

build

1 similar comment
@sameerz
Copy link
Collaborator

sameerz commented Mar 4, 2022

build

@res-life res-life merged commit 12bd1e6 into NVIDIA:branch-22.04 Mar 7, 2022
@res-life res-life deleted the minor-log-change branch March 7, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add diagnostics what shims cause "git revisions between shims are not equal"
4 participants