Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace MetadataAttribute with FileSourceMetadataAttribute to follow the update in Spark for 3.3.0+ #4934

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

firestarman
Copy link
Collaborator

@firestarman firestarman commented Mar 11, 2022

This PR is to replace MetadataAttribute with FileSourceMetadataAttribute when tagging the FileSourceScan to follow the update in Spark for 3.3.0+.

There are already tests for the this feature.

Spark PR: apache/spark@7ed51bbbe5

closes #4868

Signed-off-by: Firestarman firestarmanllc@gmail.com

…the update in Spark3.3.0+

Spark PR: apache/spark@7ed51bbbe5

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
@firestarman firestarman requested a review from nartal1 March 11, 2022 06:02
@firestarman
Copy link
Collaborator Author

build

@sameerz sameerz added the audit_3.3.0 Audit related tasks for 3.3.0 label Mar 11, 2022
@sameerz sameerz added this to the Feb 28 - Mar 18 milestone Mar 11, 2022
@sperlingxx
Copy link
Collaborator

LGTM

@firestarman
Copy link
Collaborator Author

@nartal1 Could you help review ?

Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @firestarman!

@firestarman firestarman merged commit eda23d8 into NVIDIA:branch-22.04 Mar 14, 2022
@firestarman firestarman deleted the file-source-meta branch March 14, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit_3.3.0 Audit related tasks for 3.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA][Audit] [SPARK-38159][SQL] - Update MetadataAttribute for the Hidden File Metadata
4 participants