Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for the 22.04 release[skip ci] #4997

Merged
merged 36 commits into from
Apr 7, 2022
Merged

Update docs for the 22.04 release[skip ci] #4997

merged 36 commits into from
Apr 7, 2022

Conversation

viadea
Copy link
Collaborator

@viadea viadea commented Mar 21, 2022

Update 2204 doc including add a download page section

@viadea
Update 2204 doc including add a download page section
2e817ac 
Signed-off-by: Hao Zhu <hazhu@nvidia.com>
@viadea viadea added the documentation Improvements or additions to documentation label Mar 21, 2022
@jlowe jlowe added this to the Mar 21 - Apr 1 milestone Mar 21, 2022
@tgravescs tgravescs changed the title Update 2204 doc including add a download page section[skip ci] Update docs for the 22.04 release[skip ci] Mar 21, 2022
jlowe
jlowe reviewed Mar 21, 2022
View reviewed changes
docs/FAQ.md Outdated Show resolved Hide resolved
docs/FAQ.md Outdated Show resolved Hide resolved
docs/FAQ.md Outdated Show resolved Hide resolved
docs/FAQ.md Outdated Show resolved Hide resolved
tgravescs
tgravescs reviewed Mar 21, 2022
View reviewed changes
docs/FAQ.md Show resolved Hide resolved
docs/download.md Outdated

CUDA & NVIDIA Drivers*: 11.x & v450.80.02+

Apache Spark 3.1.1, 3.1.2, 3.1.3, 3.2.0, 3.2.1, 3.3.0, Cloudera CDP 7.1.6, 7.1.7, Databricks 9.1 ML LTS or 10.4 ML LTS Runtime and GCP Dataproc 2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are we doing with CDP here, we don't have the code in our shim to actually work with those.
@sameerz Should just point to their release info ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we completely remove CDP versions from download page like what we did for EMR before?

How about we add the CDP version in FAQ with below 2 links?
https://docs.cloudera.com/cdp-private-cloud-base/7.1.6/yarn-allocate-resources/topics/yarn-using-gpu-scheduling.html
https://docs.cloudera.com/cdp-private-cloud-base/7.1.7/yarn-allocate-resources/topics/yarn-using-gpu-scheduling.html

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some discussion, i added a section in FAQ guide for CDP/CDS and also removed from download page. Please take it look at again to see if it looks good to you?

viadea and others added 5 commits March 21, 2022 12:51
@viadea @jlowe
Update docs/FAQ.md
5a565fe 
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
@viadea @jlowe
Update docs/FAQ.md
4eba485 
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
@viadea @jlowe
Update docs/FAQ.md
50b8173 
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
@viadea @jlowe
Update docs/FAQ.md
5a5f0cf 
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
@viadea
reword on FAQ
99df03d 
Signed-off-by: Hao Zhu <hazhu@nvidia.com>
sameerz
sameerz reviewed Mar 21, 2022
View reviewed changes
Copy link
Collaborator

@sameerz sameerz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this now mention CUDA 11.5?
"What hardware is supported?

The plugin is tested and supported on V100, T4, A2, A10, A30 and A100 datacenter GPUs. It is possible to run the plugin on GeForce desktop hardware with Volta or better architectures. GeForce hardware does not support CUDA forward compatibility, and will need CUDA 11.2 installed. If not, the following error will be displayed:"

@viadea
Change to CUDA 11.5 in FAQ guide
b9a0a6f 
Signed-off-by: Hao Zhu <hazhu@nvidia.com>
@viadea
Copy link
Collaborator Author

viadea commented Mar 22, 2022

?

Just changed to CUDA 11.5 in FAQ.

abellina
abellina reviewed Mar 22, 2022
View reviewed changes
docs/FAQ.md Outdated Show resolved Hide resolved
abellina
abellina reviewed Mar 22, 2022
View reviewed changes
docs/FAQ.md Outdated Show resolved Hide resolved
abellina
abellina reviewed Mar 22, 2022
View reviewed changes
docs/FAQ.md Outdated Show resolved Hide resolved
abellina
abellina reviewed Mar 22, 2022
View reviewed changes
docs/FAQ.md Outdated Show resolved Hide resolved
abellina
abellina reviewed Mar 22, 2022
View reviewed changes
docs/FAQ.md Outdated Show resolved Hide resolved
abellina
abellina reviewed Mar 22, 2022
View reviewed changes
docs/FAQ.md Outdated Show resolved Hide resolved
abellina
abellina reviewed Mar 22, 2022
View reviewed changes
docs/FAQ.md Outdated Show resolved Hide resolved
abellina
abellina reviewed Mar 22, 2022
View reviewed changes
docs/FAQ.md Outdated Show resolved Hide resolved
viadea and others added 3 commits March 22, 2022 09:59
@viadea @abellina
Update docs/FAQ.md
247b7d0 
Co-authored-by: Alessandro Bellina <abellina@gmail.com>
@viadea @abellina
Update docs/FAQ.md
4c19d8b 
Co-authored-by: Alessandro Bellina <abellina@gmail.com>
@viadea @abellina
Update docs/FAQ.md
54ee0cb 
Co-authored-by: Alessandro Bellina <abellina@gmail.com>
@sameerz
Copy link
Collaborator

sameerz commented Apr 1, 2022

Can we update the FAQ section about MIG to

@sameerz
Copy link
Collaborator

sameerz commented Apr 1, 2022 •
edited
Loading

Please update docs/get-started/getting-started.md to up the minimum Apache Spark requirement to 3.1x

`To enable GPU processing acceleration you will need:

Apache Spark 3.1+`

sameerz
sameerz requested changes Apr 1, 2022
View reviewed changes
docs/demo/Databricks/generate-init-script-cuda11.ipynb Outdated Show resolved Hide resolved
docs/download.md Outdated Show resolved Hide resolved
docs/download.md Outdated Show resolved Hide resolved
docs/demo/Databricks/generate-init-script.ipynb Outdated Show resolved Hide resolved
viadea and others added 3 commits April 1, 2022 16:23
@viadea @sameerz
Update docs/download.md
b0bab03 
Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
@viadea @sameerz
Update docs/download.md
b38b4b3 
Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
@viadea
delete generate-init-script-cuda11.ipynb
dca6600
@viadea
Copy link
Collaborator Author

viadea commented Apr 1, 2022

Please update docs/get-started/getting-started.md to up the minimum Apache Spark requirement to 3.1x

`To enable GPU processing acceleration you will need:

Apache Spark 3.1+`

Changed.

viadea added 2 commits April 1, 2022 16:37
@viadea
reformatted init script
6c76439 
Signed-off-by: Hao Zhu <hazhu@nvidia.com>
@viadea
MIG FAQ update
25ea4d6 
Signed-off-by: Hao Zhu <hazhu@nvidia.com>
@viadea
Copy link
Collaborator Author

viadea commented Apr 1, 2022

Can we update the FAQ section about MIG to

* Clarify that MIG on YARN with Docker is possible for YARN versions higher than 3.1.2

* Point to the examples https://github.com/NVIDIA/spark-rapids-examples/tree/branch-22.04/examples/MIG-Support

* Mention that MIG can be advantageous if the cluster is intended to be shared amongst other processes (like ML / DL jobs)

Added some words for this in FAQ.

sameerz
sameerz requested changes Apr 2, 2022
View reviewed changes
docs/download.md Outdated Show resolved Hide resolved
docs/demo/Databricks/generate-init-script.ipynb Show resolved Hide resolved
@viadea
Modified CLDR/EMR section in download
756b7e0 
Signed-off-by: Hao Zhu <hazhu@nvidia.com>
@sameerz sameerz modified the milestones: Mar 21 - Apr 1, Apr 4 - Apr 15 Apr 4, 2022
sameerz
sameerz previously approved these changes Apr 5, 2022
View reviewed changes
abellina
abellina reviewed Apr 5, 2022
View reviewed changes
docs/FAQ.md Outdated Show resolved Hide resolved
abellina
abellina reviewed Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@abellina abellina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor changes, but it looks good to me so far.

@viadea @abellina
Update docs/get-started/getting-started-databricks.md
353b8f4 
Co-authored-by: Alessandro Bellina <abellina@gmail.com>
@viadea @abellina
Update docs/get-started/getting-started-gcp.md
b46562e 
Co-authored-by: Alessandro Bellina <abellina@gmail.com>
abellina
abellina reviewed Apr 5, 2022
View reviewed changes
docs/FAQ.md Outdated Show resolved Hide resolved
viadea and others added 2 commits April 5, 2022 10:11
@viadea @abellina
Update docs/get-started/getting-started-databricks.md
3d551f9 
Co-authored-by: Alessandro Bellina <abellina@gmail.com>
@viadea @abellina
Update docs/FAQ.md
9eb8765 
Co-authored-by: Alessandro Bellina <abellina@gmail.com>
abellina
abellina approved these changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@abellina abellina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abellina
Copy link
Collaborator

abellina commented Apr 5, 2022

build

@viadea viadea merged commit 9208709 into NVIDIA:branch-22.04 Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgravescs tgravescs tgravescs left review comments

@jlowe jlowe jlowe left review comments

@sameerz sameerz sameerz approved these changes

@abellina abellina abellina approved these changes

@revans2 revans2 Awaiting requested review from revans2

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Apr 4 - Apr 15
Development

Successfully merging this pull request may close these issues.
5 participants
@viadea @sameerz @abellina @jlowe @tgravescs