Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references of shims folder in docs [skip ci] #5009

Merged
merged 3 commits into from
Mar 23, 2022

Conversation

razajafri
Copy link
Collaborator

partially addresses issue #4920

Signed-off-by: Raza Jafri rjafri@nvidia.com

Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri razajafri requested a review from gerashegalov March 22, 2022 18:31
revans2
revans2 previously approved these changes Mar 22, 2022
@razajafri razajafri changed the title Remove references of shims folder in docs Remove references of shims folder in docs [skip ci] Mar 22, 2022
@razajafri razajafri marked this pull request as draft March 22, 2022 18:38
@razajafri razajafri marked this pull request as ready for review March 22, 2022 18:38
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri
Copy link
Collaborator Author

I have tried to get rid of the CI requirement by pushing an empty commit but it seems like it's just easier to kick off the CI in this case instead fighting the system.

@razajafri
Copy link
Collaborator Author

build

gerashegalov
gerashegalov previously approved these changes Mar 22, 2022
Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CONTRIBUTING.md Outdated Show resolved Hide resolved
@jlowe jlowe added the documentation Improvements or additions to documentation label Mar 22, 2022
@jlowe jlowe added this to the Mar 21 - Apr 1 milestone Mar 22, 2022
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
@razajafri razajafri dismissed stale reviews from gerashegalov and revans2 via 85ce638 March 22, 2022 21:34
@razajafri razajafri requested a review from jlowe March 22, 2022 21:34
@razajafri
Copy link
Collaborator Author

build

@razajafri razajafri merged commit e0e8c17 into NVIDIA:branch-22.04 Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants