Fix profiling tool reading collectionAccumulator #5094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
|
build |
| @@ -404,8 +404,8 @@ class EventsProcessor(app: ApplicationInfo) extends EventProcessorBase[Applicati | |||
| app.accumIdToStageId.put(res._2.id, event.stageInfo.stageId) | |||
| arrBuf += thisMetric | |||
| } catch { | |||
| case e: ClassCastException => | |||
| logWarning("ClassCastException when parsing accumulables for task " + | |||
| case e: Exception => | |||
There was a problem hiding this comment.
should we catch exceptions more exhaustively with matching on Throwable?
There was a problem hiding this comment.
if it's an Error, I think we just want to fail as that could be something more than just related to the accumulable, what I actually probably should do is make this match on NonFatal(e)
There was a problem hiding this comment.
+1 for NonFatal, it's consistent with similar usages in our code base
|
build |
revans2
approved these changes
Mar 30, 2022
gerashegalov
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The profiling tool can fail to process an event log if it has custom task accumulables of type CollectionAccumulator, this just changes it to catch the exception and ignore those accumulables.
This is a minimal fix for #5091 but I want to leave that open and handle these better.
Signed-off-by: Thomas Graves tgraves@nvidia.com