Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ShimVectorizedColumnReader construction for recent Spark 3.3.0 changes #5124

Merged
merged 4 commits into from
Apr 4, 2022

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Apr 1, 2022

Fixes #5123.
Fixes #5133.

Adds in a ParsedVersion parameter which is new in the Spark 3.3.0 constructor for VectorizedColumnReader. Creation of the parameter mirrors the same logic implemented in SPARK-37974 and SPARK-34863.

In addition this contains a build fix for the QueryExecutionErrors changes in SPARK-38716.

…anges

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe added the build Related to CI / CD or cleanly building label Apr 1, 2022
@jlowe jlowe added this to the Mar 21 - Apr 1 milestone Apr 1, 2022
@jlowe jlowe self-assigned this Apr 1, 2022
@jlowe
Copy link
Member Author

jlowe commented Apr 1, 2022

build

tgravescs
tgravescs previously approved these changes Apr 1, 2022
@jlowe
Copy link
Member Author

jlowe commented Apr 1, 2022

Spark snapshots in premerge need to be updated to see the recent change.

@jlowe
Copy link
Member Author

jlowe commented Apr 1, 2022

build

@res-life
Copy link
Collaborator

res-life commented Apr 3, 2022

Another build PR: #5137

@sameerz sameerz modified the milestones: Mar 21 - Apr 1, Apr 4 - Apr 15 Apr 4, 2022
@jlowe
Copy link
Member Author

jlowe commented Apr 4, 2022

build

1 similar comment
@jlowe
Copy link
Member Author

jlowe commented Apr 4, 2022

build

@jlowe jlowe merged commit 48ce369 into NVIDIA:branch-22.06 Apr 4, 2022
@jlowe jlowe deleted the fix-shim-vectorized-column-reader branch April 4, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
4 participants