-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix markdown check issue[skip ci] #5276
fix markdown check issue[skip ci] #5276
Conversation
Signed-off-by: liyuan <yuali@nvidia.com>
Signed-off-by: liyuan <yuali@nvidia.com>
this pr is to fix the GitHub permissions issue, but I believe there are some other issues in the link check library, because there are some reference links marked as dead, but actually, they can be accessed, please see the log for more detail |
I have a concern that the updated link check is referring to a personal github repository. I notice other repos that use gaurav-nelson/github-action-markdown-link-check have fixed this issue without creating forks. Is it possible for us to explore a bit further? Also, some links are legitimately broken, and without this check we are missing those. For example, the links on https://github.com/NVIDIA/spark-rapids/blob/branch-22.06/docs/dev/shims.md for the following text are broken: |
Signed-off-by: liyuan <yuali@nvidia.com>
Signed-off-by: liyuan <yuali@nvidia.com>
add a safe directory before the actions/checkout step to work around the permission issue. |
build |
fix markdown checker permissions issue and reference links issue