Simplify conditional catalyst expressions generated by udf-compiler #5315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowe
reviewed
Apr 26, 2022
udf-compiler/src/main/scala/com/nvidia/spark/udf/CatalystExpressionBuilder.scala
Show resolved
Hide resolved
seanprime7
force-pushed
the
seanprime7/udf-compiler-conditional-simplification
branch
from
633771a to
4afaaf8
Compare
jlowe
previously approved these changes
Apr 26, 2022
|
build |
udf-compiler/src/main/scala/com/nvidia/spark/udf/CatalystExpressionBuilder.scala
Outdated
Show resolved
Hide resolved
udf-compiler/src/main/scala/com/nvidia/spark/udf/CatalystExpressionBuilder.scala
Outdated
Show resolved
Hide resolved
abellina
previously approved these changes
Apr 26, 2022
if (c) true else false => c if (c) false else true => !c Signed-off-by: Sean Lee <selee@nvidia.com>
seanprime7
force-pushed
the
seanprime7/udf-compiler-conditional-simplification
branch
from
4afaaf8 to
bba7ec3
Compare
|
@seanprime7 please do not force-push once the PR is being reviewed. It often orphans the reviewer comments and makes re-reviews more difficult. Commits are already squashed when merged, so PRs don't need to optimize their commits before merging. |
|
copy that |
jlowe
approved these changes
Apr 26, 2022
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if (c) true else false => c
if (c) false else true => !c
Signed-off-by: Sean Lee selee@nvidia.com
Resolves #3985