Add GpuEqualToNoNans and update GpuPivotFirst to use to handle PivotFirst with NaN support enabled on GPU #5418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() with NaN support enabled on GPU Signed-off-by: Navin Kumar <navink@nvidia.com>
revans2
reviewed
May 4, 2022
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/predicates.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/predicates.scala
Outdated
Show resolved
Hide resolved
…ToNoNans Signed-off-by: Navin Kumar <navink@nvidia.com>
|
build |
nartal1
reviewed
May 4, 2022
revans2
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5322.
This adds the GpuEqualToNoNans operation to support EqualTo where NaN != NaN. This is then used in GpuPivotFirst to allow GPU and CPU behavior to be consistent when the plugin knows that floats can be NaN. The check for the hasNans configuration is now removed so the operation will continue to run on the GPU even if the input data has NaN values. The integration tests have also been updated to account for
hasNansand support NaN float inputs inpivot(...)on the GPU.Signed-off-by: Navin Kumar navink@nvidia.com