QualificationTool. Add speedup information to AppSummaryInfo #5454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
tgravescs
reviewed
May 10, 2022
tools/src/main/scala/com/nvidia/spark/rapids/tool/qualification/QualOutputWriter.scala
Outdated
Show resolved
Hide resolved
| @@ -34,7 +34,7 @@ import org.apache.spark.sql.rapids.tool.qualification._ | |||
| class Qualification(outputDir: String, numRows: Int, hadoopConf: Configuration, | |||
| timeout: Option[Long], nThreads: Int, order: String, | |||
| pluginTypeChecker: PluginTypeChecker, readScorePercent: Int, | |||
| reportReadSchema: Boolean, printStdout: Boolean) extends Logging { | |||
| reportReadSchema: Boolean, printStdout: Boolean, uiEnabled: Boolean = false) extends Logging { | |||
There was a problem hiding this comment.
I would remove the uiEnabled option since its not included here.
There was a problem hiding this comment.
I agree. uiEnabled option and it's related code can be added in a different PR where we integrate the UI.
There was a problem hiding this comment.
removed the new argument.
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
nartal1
reviewed
May 11, 2022
tools/src/main/scala/org/apache/spark/sql/rapids/tool/qualification/QualificationAppInfo.scala
Show resolved
Hide resolved
|
build |
tgravescs
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me
fixes #5449
Splitting the scope of #5176 and the pending PR #5407
The changes are small. However, the total files affected by the change increased because of the CSV file expectations.
Adds the following fields to
QualificationSummaryInfoMoved
gpuModeandjobIdToInfoto AppBase because it is common between Qualification and Profiling toolMoved some common code to
EventProcessorBaseAdded the new fileds to the CSV schema of QualificationSuite and updated all the expectations. Note that those values are generated as a stub and not accurate.
Updated QualOutputWriter to dump the new fields and the Recommendation to the summary
Added UI flag to the arguments. It is false by default and enabling it has no effect until the static code generation gets merged.