Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MVN_OPT to last, as it is empty in most cases [databricks] #5534

Merged
merged 3 commits into from
May 19, 2022
Merged

MVN_OPT to last, as it is empty in most cases [databricks] #5534

merged 3 commits into from
May 19, 2022

Conversation

NvTimLiu
Copy link
Collaborator

MVN_OPT to last, as it is empty in most cases

Signed-off-by: Tim Liu timl@nvidia.com

@NvTimLiu
MVN_OPT to last, as it is empty in most cases
5649511 
Signed-off-by: Tim Liu <timl@nvidia.com>
@NvTimLiu NvTimLiu self-assigned this May 19, 2022
@NvTimLiu NvTimLiu requested a review from pxLi May 19, 2022 03:52
@NvTimLiu NvTimLiu added the build Related to CI / CD or cleanly building label May 19, 2022
@NvTimLiu NvTimLiu changed the title MVN_OPT to last, as it is empty in most cases MVN_OPT to last, as it is empty in most cases [[databricks]] May 19, 2022
@NvTimLiu NvTimLiu changed the title MVN_OPT to last, as it is empty in most cases [[databricks]] MVN_OPT to last, as it is empty in most cases [databricks] May 19, 2022
@NvTimLiu
Copy link
Collaborator Author

build

pxLi
pxLi approved these changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@pxLi pxLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to unblock nightly and premerge for databricks.

Please also have a ticket to follow up clean jenkinsfile and rename the build_profiles param, thanks!

pxLi
pxLi requested changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@pxLi pxLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to comment out -b to pass premerge CI as jenkinsfile in this PR won't take effect

@NvTimLiu
Copy link
Collaborator Author

build

@pxLi
Copy link
Collaborator

pxLi commented May 19, 2022 •
edited
Loading

Passed build stages. Going to force merge this one to unblock CIs.

@NvTimLiu #5535 Please help create a follow up PR to refactor param to support mvn_opt in databricks env, thanks!

@pxLi pxLi merged commit 4f29451 into NVIDIA:branch-22.06 May 19, 2022
@NvTimLiu
Copy link
Collaborator Author

Related issue: #5535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxLi pxLi pxLi approved these changes

@jlowe jlowe Awaiting requested review from jlowe jlowe is a code owner

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs is a code owner

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

Assignees

@NvTimLiu NvTimLiu

Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NvTimLiu @pxLi