-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update array_min and array_max to use new cudf operations #5571
Conversation
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Has unused imports that failed the verify build, but otherwise lgtm.
build |
Our build system is too complicated. I do a build/buildall but it does not update the docs or warn me about style. So I have to do a buildall and a regular build for a single version to get everything I need to check before pushing something. This is really frustrating. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One can obviously add whatever is missing to buildall . It does scalastyle on the lowest shim involved. At least now we receive this automated feedback in a couple of minutes instead of waiting for hours: htps://github.com/NVIDIA/spark-rapids/runs/6528205143?check_suite_focus=true |
@gerashegalov yes the few mins is so very nice compared to before. |
CUDF finished work on segmented min and segmented max for strings and decimal. This lets us delete a lot of code and hopefully thing run even faster now too.