Use Spark's Utils.getContextOrSparkClassLoader to load Shims [databricks]
#5646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gera Shegalov <gera@apache.org>
gerashegalov
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
NvTimLiu
as code owners
gerashegalov
changed the title
gerashegalov
changed the title
|
build |
…Utils.getContextOrSparkClassLoader
|
current premerge status: |
gerashegalov
added
the
task
…Utils.getContextOrSparkClassLoader
Signed-off-by: Gera Shegalov <gera@apache.org>
|
build |
|
Many more tests passed. |
…Utils.getContextOrSparkClassLoader
Signed-off-by: Gera Shegalov <gera@apache.org>
|
build |
…Utils.getContextOrSparkClassLoader
Signed-off-by: Gera Shegalov <gera@apache.org>
|
build |
|
retrigger workflows |
revans2
previously approved these changes
Aug 8, 2022
| @@ -1402,14 +1402,6 @@ object RapidsConf { | |||
| .booleanConf | |||
| .createWithDefault(true) | |||
|
|
|||
| val FORCE_SHIMCALLER_CLASSLOADER = conf("spark.rapids.force.caller.classloader") | |||
There was a problem hiding this comment.
Does anything else in spark2 use this?
There was a problem hiding this comment.
This is merely due to spark2 cloning RapidsConf source. We verified there is no actual use of spark.rapids.force.caller.classloader in the spark 2 explain support.
…Utils.getContextOrSparkClassLoader
…Utils.getContextOrSparkClassLoader
|
Upmerged and removed newer references to force.caller.classloader. Ran iceberg tests locally without issues using the local and standalone modes. |
|
build |
gerashegalov
changed the title
Utils.getContextOrSparkClassLoader to load Shims [databricks]
jlowe
approved these changes
Aug 16, 2022
gerashegalov
deleted the
gerashegalov/Utils.getContextOrSparkClassLoader
branch
This was referenced Aug 18, 2022
Closed
gerashegalov
added a commit
that referenced
this pull request
Jul 19, 2023
As of #5646 (22.10) specifying `allowConventionalDistJar` is not necessary for the newer JDK's sake. The only legitimate use case is if the user does not want side-effects of dealing with a [multi-shim jar](https://github.com/NVIDIA/spark-rapids/blob/branch-23.08/CONTRIBUTING.md#building-a-distribution-for-a-single-spark-release) ```bash JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64 mvn clean install -Dbuildver=341 -DskipTests JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64 TEST_PARALLEL=0 SPARK_HOME=~/dist/spark-3.4.1-bin-hadoop3 ./integration_tests/run_pyspark_from_build.sh -s -k array_exists ``` Signed-off-by: Gera Shegalov <gera@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3851
Spark loads external datasources using
Utils.getContextOrSparkClassLoaderTrampoline to
Utils.getContextOrSparkClassLoaderto make our current code work with external sources, and to unblock JDK9+Signed-off-by: Gera Shegalov gera@apache.org