-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GPU ORC statistics write support #5715
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
build |
tgravescs
reviewed
Jun 1, 2022
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
build |
sameerz
reviewed
Jun 2, 2022
docs/compatibility.md
Outdated
RAPIDS does not support whole file statistics in ORC file. We are working with | ||
[CUDF](https://github.com/rapidsai/cudf) to support writing statistics and you can track it | ||
[here](https://github.com/rapidsai/cudf/issues/5826). | ||
RAPIDS does not support whole file statistics in ORC file in releases _prior_ to release 22.06. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
Suggested change
RAPIDS does not support whole file statistics in ORC file in releases _prior_ to release 22.06. | |
RAPIDS does not support whole file statistics in ORC file in releases prior to release 22.06. |
tgravescs
previously approved these changes
Jun 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine pending the existing comment
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
build |
sameerz
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me
closes #4860
Followup after Closing CUDF-Issue 5826 [BUG] ORC file-level statistics omitted with chunked writes.
mode(overwrite)
. Otherwise, the integration test fails because the file already exists.How it was testes: