-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for regexp_extract_all on GPU #5968
Merged
anthony-chang
merged 20 commits into
NVIDIA:branch-22.08
from
anthony-chang:regexp-extract-all-positive-idx
Jul 14, 2022
Merged
Add support for regexp_extract_all on GPU #5968
anthony-chang
merged 20 commits into
NVIDIA:branch-22.08
from
anthony-chang:regexp-extract-all-positive-idx
Jul 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apids into regexp-extract-all
Signed-off-by: Anthony Chang <antchang@nvidia.com>
Signed-off-by: Anthony Chang <antchang@nvidia.com>
Signed-off-by: Anthony Chang <antchang@nvidia.com>
Signed-off-by: Anthony Chang <antchang@nvidia.com>
Signed-off-by: Anthony Chang <antchang@nvidia.com>
Signed-off-by: Anthony Chang <antchang@nvidia.com>
…gexp-extract-all-positive-idx
Signed-off-by: Anthony Chang <antchang@nvidia.com>
Signed-off-by: Anthony Chang <antchang@nvidia.com>
Signed-off-by: Anthony Chang <antchang@nvidia.com>
Signed-off-by: Anthony Chang <antchang@nvidia.com>
andygrove
reviewed
Jul 8, 2022
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
…gexp-extract-all-positive-idx
andygrove
reviewed
Jul 8, 2022
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Jul 8, 2022
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Anthony Chang <antchang@nvidia.com>
Signed-off-by: Anthony Chang <antchang@nvidia.com>
andygrove
approved these changes
Jul 8, 2022
build |
…gexp-extract-all-positive-idx
build |
1 similar comment
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4283, closes #4353
Depends on: rapidsai/cudf#11196 rapidsai/cudf#11215 being merged first
This PR adds support for Spark's
regexp_extract_all
idx
= 0, this maps cleanly to cuDF'sfindall_record
idx
> 0, cuDF'sextract_all_record
doesn't let you specify an index, so it's a bit more complicated:cudf::strings::extract_all_record
returns a list column containing all the matches, but we only want the ones specified by the groupidx
idx
. We do this withColumnVector.extractListElement
for each index we want.ColumnVector.extractListElement
returns null when the index is out of bounds of a list, so we then filter out the null values in the lists.