Allow *, ?, and {0,...} variants in StringSplit in non-empty match situations
#6959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t * and ? can still be used in other circumstances Signed-off-by: Navin Kumar <navink@nvidia.com>
…match Signed-off-by: Navin Kumar <navink@nvidia.com>
|
build |
sameerz
added
the
task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4884.
This enables
*,?as well as{0,}and{0,n}in regular expressions that used in StringSplit in most circumstances aside from zero-width match cases (covered by #6958) to run on the GPU.Because zero-width matches are a somewhat rare edge case that need to be handled on the output side, in favor of usability, this PR reduces that to be a separate edge case that can fallback on its own.