WIP: Re-enable GpuJsonToStruct support for parsing JSON as structs [databricks]
#9371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
GpuJsonToStruct regressionGpuJsonToStruct support for parsing JSON as structs
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
changed the title
GpuJsonToStruct support for parsing JSON as structsGpuJsonToStruct support for parsing JSON as structs [databricks]
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8558
I am not familiar with the history of
GpuJsonToStruct, but we had all the code for converting JSON to struct but it could never be invoked because GpuOverride was falling back to CPU for this use case.This PR updates the GpuOverrides logic and enables some tests.
The test provided in the issue still fails though. It appears that
GpuJsonToStructis now working, but there is a secondary issue with casting the struct to string for display when callingDataFrame.show, so I am leaving the issue open until I resolve that.