Upstream MQTTS without client certificate #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuastorch
changed the title
|
Hi @joshuastorch , thank you very much for the pull request :) Apologies for the late reaction, I was on holiday last week. Looks good, I'll take a closer look & do a quick test tomorrow, then merge it! |
windBlaze
approved these changes
Aug 20, 2023
There was a problem hiding this comment.
Feat approved :) New code is more flexible & the initialization and configuration of the TLS config is more straightforward. Thank you very much @joshuastorch !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation did not allow to establish an upstream connection without providing a client certificate resulting in
FATAL server: loadkeys: tls: failed to find any PEM data in certificate input.As the implementation that I tested did not support client certificates I made them optional for the upstream connection.